-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.3.0 remove a layer of indirection (unnecessary passthrough) #49
Conversation
this.write = new Writable({ | ||
write: this.#socket.write.bind(this.#socket), | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks disgusting. i love it.
|
||
read: Readable; | ||
write: Writable; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also have this be a getter for symmetry?
userFacingWrite.pipe(this.#socket); | ||
this.read = userFacingRead; | ||
this.write = userFacingWrite; | ||
this.#socket = new ReadStream(this.#fd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.#socket = new ReadStream(this.#fd) | |
this.#socket = new ReadStream(this.#fd); |
ewwww semicolonless code.
we shouldnt use passthrough if we dont need it, we got wrecked by the default watermark on the passthrough stream